Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchestrator: Generate MPEG7 perceptual hashes for fast verification #2036

Merged
merged 6 commits into from
Sep 28, 2021

Conversation

jailuthra
Copy link
Contributor

@jailuthra jailuthra commented Sep 21, 2021

What does this pull request do? Explain your changes. (required)

Add capability to generate mpeg7 perceptual hashes on the transcoder node, and send them back to the broadcaster with the renditions.

Specific updates (required)

How did you test each of these updates (required)

Locally tested that perceptual hashes are being generated in both combined and split O-T setups, if the B asks for it by setting md.CalcPerceptualHash = true. Also tested that the URI communicated from O to B for downloading the pHash works.

Does this pull request close any open issues?

Fixes #2035

Checklist:

@jailuthra jailuthra linked an issue Sep 21, 2021 that may be closed by this pull request
@jailuthra jailuthra marked this pull request as ready for review September 24, 2021 04:40
server/ot_rpc.go Outdated Show resolved Hide resolved
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

core/orchestrator.go Outdated Show resolved Hide resolved
core/orchestrator.go Show resolved Hide resolved
core/transcoder.go Outdated Show resolved Hide resolved
core/transcoder.go Outdated Show resolved Hide resolved
server/ot_rpc.go Outdated Show resolved Hide resolved
server/segment_rpc.go Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing :shipit:

core/orchestrator.go Outdated Show resolved Hide resolved
@jailuthra jailuthra merged commit c170e46 into master Sep 28, 2021
@jailuthra jailuthra deleted the jai/mpeg7-cap-orch branch September 29, 2021 02:43
jailuthra added a commit that referenced this pull request Sep 29, 2021
jailuthra added a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPEG-7 video signature capability on orchestrators
3 participants