Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update help description for {min,max}GasPrice #2041

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Update help description for {min,max}GasPrice #2041

merged 1 commit into from
Sep 28, 2021

Conversation

Strykar
Copy link
Contributor

@Strykar Strykar commented Sep 27, 2021

What does this pull request do? Explain your changes. (required)
Indicate expected values are in wei, and pose an example so it's clear given current gas prices.

Specific updates (required)
N/A

How did you test each of these updates (required)
It's just a text change for the -help context displayed by the livepeer binary.
No changes to function.

Does this pull request close any open issues?
Closes #2032

Checklist:

Indicate expected values are in wei, and pose an example so it's clear given current gas prices. Closes #2032
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Thanks @Strykar!

@yondonfu yondonfu merged commit e19172b into livepeer:master Sep 28, 2021
yondonfu pushed a commit that referenced this pull request Sep 28, 2021
@Strykar Strykar deleted the patch-1 branch September 28, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not clear what units to use for -maxGasPrice value
2 participants