server: Add safety checks in selectOrchestrator #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
force-pushed
the
yf/safety-checks
branch
from
6d479f2
to
108abdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds safety checks in
selectOrchestrator()that will skip the broadcast session creation for an O if it is either missing an auth token or ticket params (only if the B is running in on-chain mode) in its OrchestratorInfo message.Specific updates (required)
See commit history.
How did you test each of these updates (required)
Added unit tests.
Does this pull request close any open issues?
N/A
Checklist:
makeruns successfully./test.shpass