Enable fast verification on broadcaster #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the verificationFreq > 0 we should ask the Os to generate perceptual hashes, and download those hashes, regardless of how many Os are available or if we can even compare those hashes.
Once a session is verified, we use it for subsequent segments, as long as it is selected in the 3 sessions returned from the pools.
Instead of sticking to a verified orchestrator throughout the stream, we run verification probabilistically on 1/VerificationFreq segments.
If fast verification is disabled, default to selecting from untrusted pool first, only switching to trusted pool if no untrusted Os are available.
…n_using_current_sessions_total metrics should be gauge
jailuthra
commented
Nov 2, 2021
|
|
||
| func (o *orchestratorPool) SizeWith(scorePred common.ScorePred) int { | ||
| var size int | ||
| for _, info := range o.infos { |
There was a problem hiding this comment.
There's an occasional panic on this line, that I suspect is due to o == nil
yondonfu
approved these changes
Nov 2, 2021
This was referenced Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Merge fast verification branch into master
Specific updates (required)
Commits already reviewed in separate PRs
How did you test each of these updates (required)
Manually tested that features work after rebasing with master
Does this pull request close any open issues?
Fixes https://github.com/livepeer/internal-project-tracking/issues/229
Checklist:
makeruns successfully./test.shpass