Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check verified session first while choosing the result from multiple untrusted sessions #2100

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Nov 10, 2021

What does this pull request do? Explain your changes. (required)
When there are multiple untrusted sessions (orchestrators), then check first the result from the verified session. This is one of the changes that will prevent bouncing between different orchestrators while transcoding a stream.

related to #2097

Note: This change alone does not completely prevent bouncing between different sessions. Swapping sessions also occur here.

Specific updates (required)

  • Refactor broadcast.go: extract collectResults() function to make it testable
  • Add unit test for collectResults()
  • Make verified session returned first from collectResults()

How did you test each of these updates (required)

  1. Add printing the currently verified session and the result session
  2. Build the project
  3. Run the local setup with 1 trusted orchestrator and 3 untrusted orchestrator
  4. Check that the currently verified session is always the one selected from multiple results

Does this pull request close any open issues?

Checklist:

Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jailuthra jailuthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leszko leszko force-pushed the 2097-default-to-1-untrusted-orch branch from cbd6246 to 56e71d7 Compare November 22, 2021 08:17
@leszko leszko merged commit 2f6c226 into livepeer:master Nov 22, 2021
@leszko leszko deleted the 2097-default-to-1-untrusted-orch branch November 22, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants