Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mpeg7 cuda signature filter memory leak #2108

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

oscar-davids
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

Before fixing this, there was a CPU and GPU memory leak. The memory used when closing the signature_cuda filter is freed.

Copy link
Contributor

@jailuthra jailuthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update to go.mod to latest LPMS commit livepeer/lpms#273
And go mod tidy afterwards.

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before merging let's squash into a single commit with a message that looks like this one 8ff2613. Except of course we'd reference the latest LPMS commit instead.

Copy link
Contributor

@jailuthra jailuthra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oscar-davids oscar-davids merged commit 7db8c33 into master Nov 22, 2021
@yondonfu yondonfu deleted the oc/fixsignleak branch November 22, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants