cmd/livepeer_bench: add option to repeat benchmark #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jailuthra
added a commit
that referenced
this pull request
Nov 22, 2021
jailuthra
requested review from
oscar-davids and
yondonfu
and removed request for
oscar-davids
yondonfu
reviewed
Nov 22, 2021
cmd/livepeer_bench/livepeer_bench.go
Outdated
| } | ||
| if ffmpeg.Software != accel { | ||
| in.Device = devices[k%len(devices)] | ||
| for repeat_counter := 0; repeat_counter < *repeat; repeat_counter++ { |
There was a problem hiding this comment.
Nit: Suggest using camel case here to follow Go idiom.
jailuthra
force-pushed
the
jai/repeat-bench
branch
from
1015c99
to
a0aec8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Add option to repeat the benchmark process for more than 1 times. This is helpful to reproduce if we want to monitor VRAM usage when closing and re-opening GPU sessions.
Specific updates (required)
See commit history
How did you test each of these updates (required)
Manually tested that setting
-repeat <N>leads to the benchmark process running#Ntimes.Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass