1656 upload timeouts #2122
Merged
1656 upload timeouts #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
reviewed
Dec 2, 2021
leszko
commented
Dec 3, 2021
leszko
force-pushed
the
1656-upload-timeouts
branch
from
03dfb66
to
166d638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
While making an HTTP request from B -> O, introduce a separate timeout for the segment data upload. Before there was one timeout for the whole request.
Specific updates (required)
How did you test each of these updates (required)
Check locally if transcoding (still) works. Then, introduced an artificial sleep in O and tried again. Note the timeout error message in B.
Does this pull request close any open issues?
fix #1656
Checklist:
makeruns successfully./test.shpass