eth: Round up bumped gas price for the replacement transactions #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
approved these changes
Dec 7, 2021
CHANGELOG_PENDING.md
Outdated
| @@ -22,6 +22,7 @@ | |||
| - \#2110 Transparently support HTTP/2 for segment requests while allowing HTTP/1 via GODEBUG runtime flags (@yondonfu) | |||
| - \#2124 Do not retry transcoding if HTTP client closed/canceled the connection (@leszko) | |||
| - \#2122 Add the upload segment timeout to improve failing fast (@leszko) | |||
| - \#2126 Round up bumped gas price for the replacement transactions (@leszko) | |||
There was a problem hiding this comment.
This can actually go in the "General" section under "Features" since this change impacts all user types.
Good idea, updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Replacement transactions increase the max gas fee by 11%. Before this change, the value was rounded down, which might have resulted in rejecting the replacement transaction (because the requirement is to have at least 10% price bump).
Specific updates (required)
applyPriceBump()function to round up instead of round downHow did you test each of these updates (required)
unit test
Does this pull request close any open issues?
N/A
Checklist:
makeruns successfully./test.shpass