Revert eth: Ensure maxFeePerGas in all transactions never exceed -masGasPrice #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sPrice defined by the user" This reverts commit d7488f2.
|
just a comment here: If it's too much work to find the issue, I'd say don't bother considering the L2 migration is only 1-2 months out. Gas price won't be an issue there anyways so not sure if it's worth it spending too much time on this :) |
This was referenced Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR: #2111 caused the following bug: #2152
We revert it for now and will implement maxGasPrice in a different manner.
What does this pull request do? Explain your changes. (required)
N/A
Specific updates (required)
N/A
How did you test each of these updates (required)
Tested that it fixes the related bug.
Does this pull request close any open issues?
fix #2152
Checklist:
makeruns successfully./test.shpass