Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: Update hardcoded Rinkeby Eth Controller Address #2177

Merged
merged 2 commits into from
Jan 12, 2022
Merged

cmd: Update hardcoded Rinkeby Eth Controller Address #2177

merged 2 commits into from
Jan 12, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jan 12, 2022 •
edited
Loading

What does this pull request do? Explain your changes. (required)

Update hardcoded Rinkeby Eth Controller.

Points of attention:

  1. Orchestrators registered via the old controller and not visible via the new controller. With the new controller, I've seen the empty controller list in Rinkeby.
  2. LPT balance is not moved from the old controller to the new controller.
  3. The same with other fields (deposit, reserve, stake, etc.)

Specific updates (required)

N/A

How did you test each of these updates (required)

  • Started Broadcaster
  • Invoked "Get test LPT"
  • Invoked "deposit broadcasting funds (ETH)"
  • Started Orchestrator
  • Register / Activate Orchestrator

Does this pull request close any open issues?

fix #2166

Checklist:

@leszko leszko requested a review from yondonfu January 12, 2022 10:23
@yondonfu yondonfu merged commit d4dbc20 into livepeer:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update hardcoded Controller address for Rinkeby for new testnet
2 participants
@leszko @yondonfu