Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate contract bindings for Arbitrum + related fixes #2180

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Generate contract bindings for Arbitrum + related fixes #2180

merged 5 commits into from
Jan 20, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jan 13, 2022 •
edited
Loading

What does this pull request do? Explain your changes. (required)
Regenerate contract bindings related to the confluence protocol upgrade.

Specific updates (required)

How did you test each of these updates (required)

  • Orchestrator registration + streaming workflow (as described here)
  • Calling withdrawFees from Livepeer CLI created this transaction

Does this pull request close any open issues?

fix https://github.com/livepeer/internal-project-tracking/issues/287

Checklist:

@leszko leszko requested a review from yondonfu January 13, 2022 10:24
yondonfu
yondonfu requested changes Jan 18, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments. Also, let's also sync dev with master to pull in some of the testing fixes so that CI won't consistently fail for this PR.

cmd/livepeer_cli/wizard_bond.go Outdated Show resolved Hide resolved
server/webserver.go Outdated Show resolved Hide resolved
@leszko leszko changed the base branch from dev to benchmarking January 19, 2022 17:17
@leszko leszko changed the base branch from benchmarking to dev January 19, 2022 17:17
@leszko leszko requested a review from yondonfu January 19, 2022 18:02
yondonfu
yondonfu approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment about removing an extraneous CHANGELOG_PENDING entry - feel free to remove prior to merging.

CHANGELOG_PENDING.md Outdated Show resolved Hide resolved
server/handlers.go Show resolved Hide resolved
@yondonfu yondonfu mentioned this pull request Jan 19, 2022
Closed
5 tasks
@leszko leszko merged commit 0cb9cd2 into livepeer:dev Jan 20, 2022
@leszko leszko deleted the arbitrum-testnet branch January 20, 2022 10:22
@yondonfu yondonfu mentioned this pull request Jan 24, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leszko @yondonfu