cmd/livepeer: Add support for -j flag for mist connector
#2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
approved these changes
Jan 21, 2022
victorges
changed the title
-j flag from the livepeer binary for mist connector.-j flag from the livepeer binary for mist connector.
victorges
changed the title
-j flag from the livepeer binary for mist connector.-j flag for mist connector.
victorges
changed the title
-j flag for mist connector.-j flag for mist connector
|
FTR I updated the PR description to match the go-livepeer pattern as well. We should always prefix with the package that is being updated |
yondonfu
reviewed
Jan 23, 2022
There was a problem hiding this comment.
+1 for the comments by @victorges on changelog [1] + commit structure. Other than that looks good!
[1] See https://github.com/livepeer/go-livepeer/blob/master/doc/contributing.md#changelog
Add changelog entry.
hjpotter92
force-pushed
the
hjp/mist-runtime-support
branch
from
4ab707c
to
3997992
Compare
Updated the pending changelog! Thanks for the pointers :) I'm also not sure why the build tests are failing after changelog updates 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Add support for
-jflag to the built binaries which prints json information. This json is used by mist controller to launch dependent applications.Specific updates (required)
-jflag tolivepeerbinaryHow did you test each of these updates (required)
Building the package locally, and testing with an added controller in mist runtime configuration.
Does this pull request close any open issues?
related to #2181
Checklist:
makeruns successfully./test.shpass