Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2210 fix windows end of line #2216

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jan 26, 2022

What does this pull request do? Explain your changes. (required)
Display Ctrl+Z instead of Ctrl+D for Windows.

Specific updates (required)
N/A

How did you test each of these updates (required)

  • Tested if it works as before on MacOS
  • Checked in GH Actions that in case of Windows Ctrl+Z is printed (link)

Does this pull request close any open issues?
fix #2210

Checklist:

@leszko leszko requested a review from yondonfu January 26, 2022 10:21
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of conditional build tags!

LGTM!

@leszko leszko merged commit bc41dda into livepeer:master Jan 27, 2022
@leszko leszko deleted the 2210-fix-windows-end-of-line branch January 27, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI typed data flow needs updated instructions for windows
2 participants