Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display http status codes in livepeer_cli #2218

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Display http status codes in livepeer_cli #2218

merged 2 commits into from
Jan 31, 2022

Conversation

noisersup
Copy link
Contributor

@noisersup noisersup commented Jan 28, 2022 •
edited by leszko
Loading

What does this pull request do? Explain your changes. (required)
Adds to error messages in livepeer_cli their status codes for better error understanding.

Specific updates (required)

  • changed error message in wizard.currentRound and wizard.currentBlock

How did you test each of these updates (required)

standard ./test.sh check

Does this pull request close any open issues?

Fixes #2217

Checklist:

@noisersup noisersup force-pushed the GH-2217 branch 2 times, most recently from c7bb50a to 5a639e9 Compare January 30, 2022 07:14
@leszko leszko self-requested a review January 31, 2022 10:53
leszko
leszko approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit 09321bf into livepeer:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszko leszko leszko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return http response codes in livepeer_cli responses
2 participants
@noisersup @leszko