Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter capabilities check: encoding session limit, verbose errors #2259

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

cyberj0g
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

  • Check for Nvidia encoding session limit when testing hardware capabilities
  • Immediately fail if some default capability is not supported on hardware
  • Display verbose error messages

Specific updates (required)

  • Extend and refactor TestTranscoderCapabilities function, which is called on node startup

How did you test each of these updates (required)
Manually.

Does this pull request close any open issues?

#2230

Checklist:

Copy link
Contributor

@AlexKordic AlexKordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

Copy link
Contributor

@oscar-davids oscar-davids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyberj0g cyberj0g merged commit a8af913 into master Feb 16, 2022
@hjpotter92 hjpotter92 deleted the ip/cap-check branch September 26, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants