Fix nil pointer in the block header logs #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
approved these changes
Feb 16, 2022
| if err != nil { | ||
| return header, err | ||
| } | ||
| header.L1BlockNumber = fetchedBlock.L1BlockNumber |
There was a problem hiding this comment.
Ah so the problem was that if header contained logs that were previously added to it we could end up returning a MiniHeader returned by HeaderByHash that does not have those logs. And the fix here is to make sure we copy over the L1BlockNumber from the MiniHeader returned by HeaderByHash to the header that is passed in to ensure that if the header passed in contains logs that they are preserved?
There was a problem hiding this comment.
Yes, exactly as you described. Before, I thought that what we get from the RPC call already include in logs, but apparently that's not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes a bug introduced in #2222, block header logs were not preserved while enriching block with L1 Number.
Specific updates (required)
How did you test each of these updates (required)
Unit test + checked in the debug that events returned from L2 API may not contain logs.
Does this pull request close any open issues?
fix #2265
Checklist:
makeruns successfully./test.shpass