workflow: Setup checksum generation and gpg signing for releases. #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split test as its own workflow. Tests should be run for each individual branch. - Add an `.editorconfig` file for cross-IDE settings. - Update execution bit from source text file.
Update `upload_build` script to publish archives into a `RELEASES_DIR`.
hjpotter92
force-pushed
the
hjp/release-signing
branch
from
9c6a48a
to
e1d7427
Compare
hjpotter92
force-pushed
the
hjp/release-signing
branch
from
6f33666
to
a775aca
Compare
|
The actual gpg/checksum generation workflow needs it to be merged to master branch first... bootstrap paradox |
Update installer script with gpg and checksum verification steps.
https://github.com/actions/upload-artifact#uploading-to-the-same-artifact The different files being uploaded to same artifacts get bundled together.
yondonfu
reviewed
Mar 9, 2022
There was a problem hiding this comment.
Great PR!
A few questions:
- What benefits are there is moving all platform build steps into a single workflow file? Or is this just an organizational change?
- IIUC these changes will result in a new release being published after each merge to master. That's cool. Maybe we should mark all of those as pre-releases to distinguish them from formal semver releases. WDYT? The pre-releases could then just use pre-generated release notes with a changeset and the formal semver releases could include a little more extra description since those would be for bigger milestones
|
Thanks!
The release action was getting triggered after any of the dependent workflows completed. This is currently a limitation of github actions.
The release workflow runs for merges to master branch, but the release would be created only for semver releases (based on the action check below): - uses: actions-ecosystem/action-regex-match@v2
id: match-tag
with:
text: ${{ github.event.workflow_run.head_branch }}
regex: "^v([0-9]+\.\d+\.\d+)$" |
yondonfu
reviewed
Mar 11, 2022
ad-astra-video
pushed a commit
to ad-astra-video/go-livepeer
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Does this pull request close any open issues?
Fixes #2147