doc: Fix syntax errors in example JSON #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove trailing commas * FPS has to be an integer * Profile has to be a string
AlexKordic
approved these changes
Apr 5, 2022
AlexKordic
reviewed
Apr 5, 2022
cyberj0g
reviewed
Apr 5, 2022
| },{ | ||
| "name":"highlight-reel", | ||
| "width":160, | ||
| "height":120, | ||
| "bitrate":100000, | ||
| "fps": "0.1", | ||
| "gop":"intra", | ||
| "fps": 1, |
There was a problem hiding this comment.
Maybe original intention was to highlight that fractional FPS are supported? e.g. 24000/1001 and 30000/1001 are obsolete, but still quite common.
There was a problem hiding this comment.
Yeah, that could've been the original intent but looks like it's an int now
Line 1043 in d655332
ad-astra-video
pushed a commit
to ad-astra-video/go-livepeer
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Adjust sample config JSON to be valid and usable
Specific updates (required)
How did you test each of these updates (required)
Started local Broadcaster using this config
Does this pull request close any open issues?
No
Checklist:
makeruns successfully./test.shpass