core: Fix standalone orchestrator not crashing under UnrecoverableError #2352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fix the issue that O does not fail after the unrecoverable error from lpms (ffmpeg).
The issue is described in this Discord thread. In short, when GPU crashes, NVIDIA recommends restarting the whole process, since it's not possible to recover. It worked that way until the Gracefully notify orchestrator in case of a panic in transcoder PR. In the mentioned PR, the following logic was implemented:
The logic is fine for the split O/T topology, however for the combined OT, there is a separate code which also needs to implement Point 3. Panic.
Specific updates (required)
How did you test each of these updates (required)
Artificially introduce
panic()
and check that a standalone O crashes.Does this pull request close any open issues?
Checklist:
make
runs successfully./test.sh
passREADME and other documentation updated