Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.yaml: Upload test coverage reports to codecov. #2372

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

hjpotter92
Copy link
Member

What does this pull request do? Explain your changes. (required)
Upload code coverage reports to https://codecov.io

Specific updates (required)

  • restrict test suite unless PR is to the master branch
  • upload code coverage reports to codecov dashboard

How did you test each of these updates (required)
github action

Does this pull request close any open issues?
No

Checklist:

@leszko
Copy link
Contributor

leszko commented Apr 25, 2022

@hjpotter92 Thanks for the PR.

  1. Do you have somewhere how the result of this looks like? I understand that in this PR we don't see anything in codecov.io, because it creates coverage only for the master branch. But maybe you have a result of how it works in your fork?

  2. Is it possible to make it working somehow also for PRs? It'd be nice to see how a PR affects the code coverage.

@hjpotter92
Copy link
Member Author

  1. Do you have somewhere how the result of this looks like? I understand that in this PR we don't see anything in codecov.io, because it creates coverage only for the master branch. But maybe you have a result of how it works in your fork?

You can see coverage reports for other projects:

  1. Is it possible to make it working somehow also for PRs? It'd be nice to see how a PR affects the code coverage.

it works with open pull requests against master branch. The default codecov token (set at organisation level) hits API limits, that's why some PRs miss report generation. I'll have a discussion w/ Eli wrt the same. The code in workflow itself doesn't need any change. You can check an example report on currently open PR here: livepeer/studio#1014

@leszko
Copy link
Contributor

leszko commented Apr 26, 2022

  1. Do you have somewhere how the result of this looks like? I understand that in this PR we don't see anything in codecov.io, because it creates coverage only for the master branch. But maybe you have a result of how it works in your fork?

You can see coverage reports for other projects:

  1. Is it possible to make it working somehow also for PRs? It'd be nice to see how a PR affects the code coverage.

it works with open pull requests against master branch. The default codecov token (set at organisation level) hits API limits, that's why some PRs miss report generation. I'll have a discussion w/ Eli wrt the same. The code in workflow itself doesn't need any change. You can check an example report on currently open PR here: livepeer/livepeer-com#1014

Nice! LGTM 👍

@hjpotter92 hjpotter92 merged commit e3f9286 into master Apr 26, 2022
@hjpotter92 hjpotter92 deleted the hjp/coverage branch April 26, 2022 08:28
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants