Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Fix error in orchestrator registration #2390

Merged
merged 1 commit into from
May 10, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented May 9, 2022

What does this pull request do? Explain your changes. (required)

After the handlers refactoring PR, user may see an error message while registering the orchestrator.

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@leszko leszko requested a review from thomshutt May 9, 2022 19:08
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #2390 (38f5a5a) into master (1e5ce2a) will increase coverage by 0.01541%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2390         +/-   ##
===================================================
+ Coverage   54.50763%   54.52304%   +0.01541%     
===================================================
  Files             93          93                 
  Lines          19467       19467                 
===================================================
+ Hits           10611       10614          +3     
+ Misses          8267        8264          -3     
  Partials         589         589                 
Impacted Files Coverage Δ
cmd/livepeer_cli/wizard.go 0.00000% <0.00000%> (ø)
discovery/db_discovery.go 65.97222% <0.00000%> (+1.04165%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5ce2a...38f5a5a. Read the comment docs.

@thomshutt thomshutt merged commit 15cdff9 into master May 10, 2022
@thomshutt thomshutt deleted the rl/fix-cli-activate-orchestrator-error branch May 10, 2022 09:23
thomshutt added a commit that referenced this pull request May 10, 2022
thomshutt added a commit that referenced this pull request May 11, 2022
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants