Fix Webhook discovery, refresh pool before getting pool size #2413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fix webhook-based discovery and remove webhook caching for Stream Tester.
Webhook-based discovery did not refresh pool while calling
size()
function which resulted in the following scenario:On
the pool is[]
(size0
)On+1
0
This affected Stream Tester which returned score
0
for bothOn+1
andOn
(even thoughOn
is down andOn+1
is up).Specific updates (required)
LP_EXTEND_TIMEOUTS
toLP_IS_ORCH_TESTER
How did you test each of these updates (required)
Running Stream Tester in staging and checking the results.
Does this pull request close any open issues?
fix #2270
fix #2370
fix #2412
Checklist:
make
runs successfully./test.sh
passREADME and other documentation updated