Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Make CLI flag casing consistent for dataDir flag #2437

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented May 27, 2022

What does this pull request do? Explain your changes. (required)
Adds dataDir as a CLI option and marks datadir as deprecated, making all our CLI options now consistently camel-cased.

How did you test each of these updates (required)

  • Added unit test
  • Ran binary with --help and checked it printed both options
  • Ran binary using both options and checked data dir specific was created

Does this pull request close any open issues?

Checklist:

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2437 (83960be) into master (06b3cdc) will decrease coverage by 0.06381%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2437         +/-   ##
===================================================
- Coverage   55.10277%   55.03896%   -0.06381%     
===================================================
  Files             93          94          +1     
  Lines          19460       19637        +177     
===================================================
+ Hits           10723       10808         +85     
- Misses          8140        8232         +92     
  Partials         597         597                 
Impacted Files Coverage Δ
cmd/livepeer/livepeer.go 46.32768% <100.00000%> (ø)
discovery/db_discovery.go 68.05556% <0.00000%> (+1.04166%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b3cdc...83960be. Read the comment docs.

@AlexKordic AlexKordic self-assigned this May 31, 2022
Copy link
Contributor

@AlexKordic AlexKordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlexKordic AlexKordic merged commit e1f00e3 into master Jun 3, 2022
@hjpotter92 hjpotter92 deleted the thom/flag-consistency branch September 26, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants