Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livepeer_cli: add menu option to exit gracefully #2438

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

emranemran
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Adding new menu option to exit livepeer_cli gracefully without having to use Ctrl+C.

Specific updates (required)

  • New menu option

How did you test each of these updates (required)
Tested locally and error code was verified. Attempted using other menu options prior to using the new exit option and everything worked as expected.

Does this pull request close any open issues?
fix #2287

Checklist:

  • Read the contribution guide
  • make runs successfully
  • [ ] All tests in ./test.sh pass --> MacM1 fails locally on unrelated error but GH actions will pass
  • README and other documentation updated
  • Pending changelog updated

@emranemran emranemran self-assigned this May 27, 2022
@emranemran emranemran requested a review from thomshutt May 27, 2022 17:16
@emranemran emranemran marked this pull request as ready for review May 31, 2022 14:01
@emranemran
Copy link
Contributor Author

Update: fixed go fmt build failure with tabs vs spaces.

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #2438 (81d7dd4) into master (9f52b93) will decrease coverage by 0.04220%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2438         +/-   ##
===================================================
- Coverage   55.00077%   54.95857%   -0.04221%     
===================================================
  Files             93          93                 
  Lines          19427       19431          +4     
===================================================
- Hits           10685       10679          -6     
- Misses          8150        8159          +9     
- Partials         592         593          +1     
Impacted Files Coverage Δ
cmd/livepeer_cli/livepeer_cli.go 0.00000% <0.00000%> (ø)
server/mediaserver.go 66.71875% <0.00000%> (-0.46875%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f52b93...81d7dd4. Read the comment docs.

@emranemran emranemran merged commit d360781 into master Jun 4, 2022
@emranemran emranemran deleted the user/emahbub/be-a-quitter branch June 4, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

livepeer_cli create quit/exit option from menu entry
3 participants