cli: Show O rather than B options when -redeemer flag set

[thomshutt]

What does this pull request do? Explain your changes. (required)
The CLI now shows Orchestrator rather than Broadcaster options when go-livepeer is running with the -redeemer flag set.

Specific updates (required)

• Add a new /IsRedeemer HTTP endpoint to avoid overloading /IsOrchestrator
• Make CLI option generation check this endpoint as well as /IsOrchestrator

How did you test each of these updates (required)
Ran the app with the -redeemer flag and the CLI before and after my change

Does this pull request close any open issues?
fix #2257

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass
• README and other documentation updated
• Pending changelog updated

[codecov]

Codecov Report

Merging #2456 (87374e6) into master (530051b) will decrease coverage by 0.01766%.
The diff coverage is 18.18182%.

@@                 Coverage Diff                 @@
##              master       #2456         +/-   ##
===================================================
- Coverage   54.86667%   54.84901%   -0.01766%     
===================================================
  Files             94          94                 
  Lines          19726       19736         +10     
===================================================
+ Hits           10823       10825          +2     
- Misses          8306        8313          +7     
- Partials         597         598          +1     

Impacted Files	Coverage Δ
cmd/livepeer_cli/livepeer_cli.go	0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_transcoder.go	0.00000% <0.00000%> (ø)
server/handlers.go	53.51598% <25.00000%> (-0.10456%)	⬇️
server/webserver.go	95.91837% <100.00000%> (+0.04207%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530051b...87374e6. Read the comment docs.

[leszko]

Added one comment, other than that LGTM.

Also, just a note on the process. You already closed the related GH Issue #2257. However I think you should:

• Keep the GH Issue open until this PR is merged
• Comment in the PR Description fix #2257 instead of #2257 (then the GH Issue will be automatically closed when the PR is merged)

[leszko]

I think that for the sake of consistency, I'd not execute w.isRedeemer() (and therefore an HTTP call) here, but rather in the place where wizard is initialized.

go-livepeer/cmd/livepeer_cli/livepeer_cli.go

Line 54 in 783bfdb

w.orchestrator = w.isOrchestrator()

Also, an idea, maybe we should just rename w.orchestrator => w.orchestratorOrRedeemer?

[thomshutt]

Thanks @leszko, I hadn't realised about the fix #commit flow, will do that next time.

I've moved the isRedeemer call as suggested, but for the rename there are some places that w.orchestrator is used where I wasn't sure if it made sense to also do it for a redeemer node: https://github.com/livepeer/go-livepeer/blob/master/cmd/livepeer_cli/livepeer_cli.go#L85

If you think it makes sense to include redeemers there, then I'll update to w.orchestratorOrRedeemer as suggested

[leszko]

That's fine what you did. Let's keep it as you coded it! 👍