Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Delete temporary env variable LP_IS_ORCH_TESTER #2462

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jun 14, 2022

What does this pull request do? Explain your changes. (required)
Orchtester does not use a separate Broadcaster anymore, so the LP_IS_ORCH_TESTER variable is not needed.

Specific updates (required)

  • Cleanup

How did you test each of these updates (required)

N/A

Does this pull request close any open issues?
fix livepeer/stream-tester#160

Checklist:

@leszko leszko requested a review from victorges June 14, 2022 08:43
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2462 (45e6a64) into master (530051b) will increase coverage by 0.01571%.
The diff coverage is 18.18182%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2462         +/-   ##
===================================================
+ Coverage   54.86667%   54.88238%   +0.01570%     
===================================================
  Files             94          94                 
  Lines          19726       19724          -2     
===================================================
+ Hits           10823       10825          +2     
+ Misses          8306        8301          -5     
- Partials         597         598          +1     
Impacted Files Coverage Δ
cmd/livepeer/livepeer.go 50.29940% <ø> (+3.37202%) ⬆️
cmd/livepeer_cli/livepeer_cli.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)
server/handlers.go 53.51598% <25.00000%> (-0.10456%) ⬇️
server/webserver.go 95.91837% <100.00000%> (+0.04207%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c9654...45e6a64. Read the comment docs.

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit 613e60b into master Jun 20, 2022
@leszko leszko deleted the rafal/delete-orch-tester branch June 20, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete LP_IS_ORCH_TESTER env variable
2 participants