Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include lpms min enc resolution #2466

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Conversation

AlexKordic
Copy link
Contributor

@AlexKordic AlexKordic commented Jun 17, 2022

What does this pull request do? Explain your changes. (required)

Include changes from PR 326.

Specific updates (required)

  • Update LPMS dependency version.
  • Fix usage of GetCodecInfoBytes() to match return types.
  • Include all LPMS commits including d82aa89e247702de2e1eed9a352c18fb4c459367

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2466 (e6b0db5) into master (530051b) will decrease coverage by 0.01766%.
The diff coverage is 41.17647%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2466         +/-   ##
===================================================
- Coverage   54.86667%   54.84901%   -0.01766%     
===================================================
  Files             94          94                 
  Lines          19726       19736         +10     
===================================================
+ Hits           10823       10825          +2     
- Misses          8306        8313          +7     
- Partials         597         598          +1     
Impacted Files Coverage Δ
cmd/livepeer_cli/livepeer_cli.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)
server/handlers.go 53.51598% <25.00000%> (-0.10456%) ⬇️
server/mediaserver.go 66.71875% <83.33333%> (ø)
server/webserver.go 95.91837% <100.00000%> (+0.04207%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c9654...e6b0db5. Read the comment docs.

@@ -15,6 +15,7 @@
#### Transcoder

### Bug Fixes 🐞
- [task-runner \#24](https://github.com/livepeer/task-runner/issues/24) rendition resolution fix for portrait input videos; Min resolution applied for Nvidia hardware (@AlexKordic)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link to the PR rather than / as well as the issue it fixes?

Copy link
Contributor Author

@AlexKordic AlexKordic Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, being another project. What do you think how to verbalize this item?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is a little unusual - I think include the PR ID at the start like normal and then have the task-runner URL somewhere in the message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed to look normal

@AlexKordic AlexKordic merged commit 9324731 into master Jun 21, 2022
@hjpotter92 hjpotter92 deleted the ak/lpms_minimum_enc_resolution branch September 26, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants