Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reward flag #2493

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Fix reward flag #2493

merged 2 commits into from
Jul 11, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jul 11, 2022

What does this pull request do? Explain your changes. (required)
Fix a bug in the reward flag. It stopped working after the refactoring PR #2351. If the flag is set explicitly to true, it does not work. This PR fixes it.

Specific updates (required)

How did you test each of these updates (required)

Tested manually

Does this pull request close any open issues?

N/A

Checklist:

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2493 (4604005) into master (5ad8ab5) will decrease coverage by 0.00827%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2493         +/-   ##
===================================================
- Coverage   54.73000%   54.72173%   -0.00827%     
===================================================
  Files             95          95                 
  Lines          19852       19855          +3     
===================================================
  Hits           10865       10865                 
- Misses          8383        8386          +3     
  Partials         604         604                 
Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.29665% <0.00000%> (-0.00661%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad8ab5...4604005. Read the comment docs.

@leszko leszko requested a review from thomshutt July 11, 2022 09:30
@leszko leszko marked this pull request as ready for review July 11, 2022 09:30
@leszko leszko merged commit 2757289 into livepeer:master Jul 11, 2022
@leszko leszko deleted the rafal/fix-reward-flag branch July 11, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants