server: Use HeaderByNumber() instead of BlockByNumber() in the function requesting LPT from faucet #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on requesting LPT from faucet
thomshutt
approved these changes
Aug 1, 2022
Yes, it's safe. |
yondonfu
reviewed
Aug 1, 2022
| @@ -1029,13 +1029,13 @@ func requestTokensHandler(client eth.LivepeerEthClient) http.Handler { | |||
| } | |||
|
|
|||
| backend := client.Backend() | |||
| blk, err := backend.BlockByNumber(r.Context(), nil) | |||
| h, err := backend.HeaderByNumber(r.Context(), nil) | |||
There was a problem hiding this comment.
Probably better to only fetch the block header as opposed to the entire block here anyway because we don't care about most of the data in the block anyway and we can just get the information we need from the slimmer header.
ad-astra-video
pushed a commit
to ad-astra-video/go-livepeer
that referenced
this pull request
Aug 23, 2022
…on requesting LPT from faucet (livepeer#2550)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
After the Arbitrum Nitro migration, the function
BlockByNumber()fromethereum/go-ethereumfails with the following message:It's related to the fact that Arbitrum uses its own transaction format, and therefore requires its own
go-ethereumfork OffchainLabs/go-ethereum.One option is to use OffchainLabs/go-ethereum, what we considered in #2470. Another option, implemented in this PR, is to find all the chain interactions that fail and fix them. I checked all the transaction executions and actually this one is the one that fails. Therefore, I suggest to continue using
ethereum/go-ethereumand merge this PR.Specific updates (required)
How did you test each of these updates (required)
Tested in Arbitrum Rinkeby Testnet
Does this pull request close any open issues?
fix #2547
Checklist:
makeruns successfully./test.shpassREADME and other documentation updated