Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print set config values on node start #2616

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Print set config values on node start #2616

merged 3 commits into from
Oct 11, 2022

Conversation

cyberj0g
Copy link
Contributor

@cyberj0g cyberj0g commented Oct 7, 2022

As discussed in #2613, echo non-nil fields of config object, which changed with CLI arguments, config file or environment variables.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #2616 (45bd8c8) into master (dc6e79d) will decrease coverage by 0.04176%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2616         +/-   ##
===================================================
- Coverage   56.44931%   56.40755%   -0.04176%     
===================================================
  Files             88          88                 
  Lines          18909       18923         +14     
===================================================
  Hits           10674       10674                 
- Misses          7656        7670         +14     
  Partials         579         579                 
Impacted Files Coverage Δ
cmd/livepeer/livepeer.go 47.28261% <0.00000%> (-3.89387%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc6e79d...45bd8c8. Read the comment docs.

Impacted Files Coverage Δ
cmd/livepeer/livepeer.go 47.28261% <0.00000%> (-3.89387%) ⬇️

@cyberj0g cyberj0g merged commit f6d115f into master Oct 11, 2022
@cyberj0g cyberj0g deleted the ip/verbose-config branch October 11, 2022 04:58
@iameli
Copy link
Member

iameli commented Oct 17, 2022

Reverting — this breaks livepeer -j by returning a bunch of non-JSON that MistController can't parse when it's booting up

1 similar comment
@iameli
Copy link
Member

iameli commented Oct 17, 2022

Reverting — this breaks livepeer -j by returning a bunch of non-JSON that MistController can't parse when it's booting up

iameli added a commit that referenced this pull request Oct 17, 2022
@cyberj0g cyberj0g mentioned this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants