Add timeout for HTTP connections

[leszko]

What does this pull request do? Explain your changes. (required)
Add timeout for the idea HTTP connections to prevent "too many files open" error.

Specific updates (required)

How did you test each of these updates (required)

Tested transcoding with combined OT and split O/T topologies.

Does this pull request close any open issues?
fix #2621

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass
• README and other documentation updated
• Pending changelog updated

[codecov]

Codecov Report

Merging #2628 (8ebeb32) into master (2298436) will increase coverage by 0.00591%.
The diff coverage is 0.00000%.

@@                 Coverage Diff                 @@
##              master       #2628         +/-   ##
===================================================
+ Coverage   56.29268%   56.29859%   +0.00591%     
===================================================
  Files             88          88                 
  Lines          19038       19036          -2     
===================================================
  Hits           10717       10717                 
+ Misses          7739        7737          -2     
  Partials         582         582                 

Impacted Files	Coverage Δ
server/rpc.go	71.81009% <0.00000%> (+0.42365%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2298436...8ebeb32. Read the comment docs.

Impacted Files	Coverage Δ
server/rpc.go	71.81009% <0.00000%> (+0.42365%)	⬆️

[thomshutt]

Should we have the other timeouts too? Maybe even just the more general Timeout? I'm not sure there's any reason for a request to take longer than that

https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

[leszko]

In general we should, but currently it would break the split O/T functionality, because /transcodeResults endpoint would also have read/write timeouts and our transcoders do not tolerate it now...

So, in general you're right, but I think to make it happen it's not a quick fix.

[thomshutt]

👍 Makes sense