Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/livepeer: Add httpIngest, localVerify to default cfg #2646

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented Nov 9, 2022

What does this pull request do? Explain your changes. (required)

This PR sets HttpIngest and LocalVerify in the default Livepeer config which allows the HttpIngest and LocalVerify values to be shown in the param table on startup if non-default values are used for either field.

Specific updates (required)

See commit history.

How did you test each of these updates (required)

Tested manually.

Does this pull request close any open issues?

N/A

Checklist:

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #2646 (0d8f659) into master (372b0d3) will decrease coverage by 0.03547%.
The diff coverage is 14.28571%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2646         +/-   ##
===================================================
- Coverage   56.29696%   56.26149%   -0.03547%     
===================================================
  Files             88          88                 
  Lines          19033       19045         +12     
===================================================
  Hits           10715       10715                 
- Misses          7736        7748         +12     
  Partials         582         582                 
Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.87570% <0.00000%> (-0.03237%) ⬇️
cmd/livepeer/livepeer.go 47.31183% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372b0d3...0d8f659. Read the comment docs.

Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.87570% <0.00000%> (-0.03237%) ⬇️
cmd/livepeer/livepeer.go 47.31183% <100.00000%> (ø)

@emranemran emranemran merged commit 3b60df2 into master Nov 9, 2022
@emranemran emranemran deleted the yf/flag-updates branch November 9, 2022 22:03
@thomshutt thomshutt mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants