Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tensorflow for content detection in a production build #2695

Merged
merged 15 commits into from
Jan 4, 2023

Conversation

cyberj0g
Copy link
Contributor

@cyberj0g cyberj0g commented Dec 19, 2022

Changes:

  • install_ffmpeg.sh now installs Tensorflow library and enables it for Ffmpeg without experimental BUILD_TAGS (no side effects when running in non-Nvidia environment)
  • Dockerfile copies Tensorflow distribution files to final container, because libtensorflow.so is loaded at runtime by Ffmpeg DNN filter and is not linked statically inside livepeer binary, like the rest of dependencies

Kudos to @hjpotter92 for helping to figure out Docker stuff.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #2695 (b88490a) into master (3d4bce7) will increase coverage by 0.00980%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2695         +/-   ##
===================================================
+ Coverage   56.34804%   56.35784%   +0.00980%     
===================================================
  Files             88          88                 
  Lines          19124       19126          +2     
===================================================
+ Hits           10776       10779          +3     
+ Misses          7760        7759          -1     
  Partials         588         588                 
Impacted Files Coverage Δ
core/orchestrator.go 77.65517% <0.00000%> (-0.21482%) ⬇️
discovery/db_discovery.go 70.75812% <0.00000%> (+1.08303%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be4c3b...b88490a. Read the comment docs.

Impacted Files Coverage Δ
core/orchestrator.go 77.65517% <0.00000%> (-0.21482%) ⬇️
discovery/db_discovery.go 70.75812% <0.00000%> (+1.08303%) ⬆️

@cyberj0g cyberj0g marked this pull request as ready for review December 20, 2022 15:21
@cyberj0g cyberj0g merged commit 82e40f9 into master Jan 4, 2023
@hjpotter92 hjpotter92 deleted the ip/enable-tensorflow-new branch January 4, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants