Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for using Rinkeby network #2696

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Dec 19, 2022

No description provided.

@leszko leszko requested a review from yondonfu December 19, 2022 15:36
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #2696 (07ca77a) into master (3d4bce7) will increase coverage by 0.00390%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2696         +/-   ##
===================================================
+ Coverage   56.34804%   56.35194%   +0.00390%     
===================================================
  Files             88          88                 
  Lines          19124       19128          +4     
===================================================
+ Hits           10776       10779          +3     
- Misses          7760        7761          +1     
  Partials         588         588                 
Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.85189% <0.00000%> (-0.00525%) ⬇️
core/orchestrator.go 77.65517% <0.00000%> (-0.21482%) ⬇️
discovery/db_discovery.go 70.75812% <0.00000%> (+1.08303%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be4c3b...07ca77a. Read the comment docs.

Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 2.85189% <0.00000%> (-0.00525%) ⬇️
core/orchestrator.go 77.65517% <0.00000%> (-0.21482%) ⬇️
discovery/db_discovery.go 70.75812% <0.00000%> (+1.08303%) ⬆️

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit b7975e5 into master Dec 20, 2022
@leszko leszko deleted the rafal/deprecate-arb-rinkeby branch December 20, 2022 08:10
@thomshutt thomshutt mentioned this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants