Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce livepeer image size #2712

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Reduce livepeer image size #2712

merged 5 commits into from
Jan 6, 2023

Conversation

cyberj0g
Copy link
Contributor

@cyberj0g cyberj0g commented Jan 5, 2023

A quick fix for reducing the size of the docker image: switched back to CUDA 10 for amd64 build. A proper fix would be to have:

  1. An image for Broadcaster, which doesn't include ./lib/* from Tensorflow distribution, but compiles with Tensorflow headers to avoid the risks and added complexity of having binaries built with different configurations depending on node type
  2. A separate Tensorflow image, which will additionally include ./lib/* from Tensorflow distribution

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #2712 (62e137b) into master (a3949f3) will not change coverage.
The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #2712   +/-   ##
=============================================
  Coverage   56.33265%   56.33265%           
=============================================
  Files             88          88           
  Lines          19131       19131           
=============================================
  Hits           10777       10777           
  Misses          7765        7765           
  Partials         589         589           
Impacted Files Coverage Δ
server/ot_rpc.go 35.34483% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9de74...62e137b. Read the comment docs.

Impacted Files Coverage Δ
server/ot_rpc.go 35.34483% <0.00000%> (ø)

@cyberj0g cyberj0g marked this pull request as ready for review January 6, 2023 07:23
@cyberj0g cyberj0g merged commit bda3edb into master Jan 6, 2023
@cyberj0g cyberj0g deleted the ip/reduce-image-size branch January 6, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants