Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: Bump go and livepeer-data version #2804

Merged
merged 12 commits into from
Jun 6, 2023
Merged

Conversation

victorges
Copy link
Member

@victorges victorges commented Jun 5, 2023

What does this pull request do? Explain your changes. (required)
This bumps livepeer-data version and fixes the breaking changes after that. Ended up also
having to upgrade go version, otherwise the build of a transitive dependency started failing.

Unblocks go-livepeer to start using catalyst-api (which uses the later version of livepeer-data).

Specific updates (required)

  • Update lib
  • go mod tidy
  • Fix build error

How did you test each of these updates (required)
make (I did the breaking change on livepeer-data myself and know it's only cosmetic)

Does this pull request close any open issues?
Informal.

Checklist:

@victorges victorges changed the title go.mod: Bump livepeer-data version go.mod: Bump livepeer-data and go version Jun 5, 2023
@victorges victorges changed the title go.mod: Bump livepeer-data and go version go.mod: Bump go and livepeer-data version Jun 5, 2023
Type changed on livepeer-data version
The upgrade indirectly added a module that requires 1.19
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2804 (ebee0af) into master (7888548) will increase coverage by 0.00978%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2804         +/-   ##
===================================================
+ Coverage   56.63383%   56.64361%   +0.00978%     
===================================================
  Files             88          88                 
  Lines          19084       19086          +2     
===================================================
+ Hits           10808       10811          +3     
+ Misses          7682        7681          -1     
  Partials         594         594                 
Impacted Files Coverage Δ
common/testutil.go 16.94915% <0.00000%> (-0.59471%) ⬇️
core/playlistmanager.go 89.71963% <ø> (ø)
eth/watchers/timewatcher.go 81.18280% <ø> (ø)
server/broadcast.go 77.48735% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7888548...ebee0af. Read the comment docs.

Impacted Files Coverage Δ
common/testutil.go 16.94915% <0.00000%> (-0.59471%) ⬇️
core/playlistmanager.go 89.71963% <ø> (ø)
eth/watchers/timewatcher.go 81.18280% <ø> (ø)
server/broadcast.go 77.48735% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member Author

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes LGTM as well. Curious what was the fix for the protoc errors? Couldn't tell from the diff.

@thomshutt
Copy link
Contributor

@victorges I didn't actually see any protoc errors, I think either it was a symptom of one of the things I fixed or something environmental

@thomshutt thomshutt merged commit 1b9da7f into master Jun 6, 2023
14 of 15 checks passed
@thomshutt thomshutt deleted the vg/chore/bump-lp-data branch June 6, 2023 16:42
@victorges
Copy link
Member Author

Weird! I guess the last build I got the protoc error was this: https://github.com/livepeer/go-livepeer/actions/runs/5181242457/jobs/9336484395

Then I think I made some changes that apparently fixed it and organized the commit history and push forced and it started working somehow haha
Maybe it was the go version inconsistency between all the files

This was referenced Aug 8, 2023
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
* go.mod: Update livepeer-data lib

* server: Fix MetadataQueue type

Type changed on livepeer-data version

* go.mod: Bump go to 1.20

The upgrade indirectly added a module that requires 1.19

* changelog: Change changelog

* Go 1.20 -> 1.20.4

* Get rid of go-version-file

* Bump lint version

* Set go version in another place

* go fmt

* Add glog goroutine to ignored leak ones

* Change order of go mod command

* Bump linter version

---------

Co-authored-by: Thom Shutt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants