Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nvidia cuda docker image version #2821

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Bump nvidia cuda docker image version #2821

merged 5 commits into from
Jul 18, 2023

Conversation

stronk-dev
Copy link
Contributor

@stronk-dev stronk-dev commented Jul 1, 2023

Old version was removed, docker builds require a version bump. Not sure if this breaks anything

@leszko
Copy link
Contributor

leszko commented Jul 3, 2023

I see that it increased the Docker image size from 1.29GB to 2.38GB. Isn't that an issue? CC: @thomshutt @hjpotter92

@hjpotter92
Copy link
Member

I see that it increased the Docker image size from 1.29GB to 2.38GB. Isn't that an issue? CC: @thomshutt @hjpotter92

image sizes aren't a problem now. we are provisioning our machines to use the entire SSD storage; instead of earlier 50GB as / partition and rest as /data. each server now has atleast 500GB of disk space to store docker images in cache and the persitant storage is handled separately (if needed).

@thomshutt
Copy link
Contributor

@hjpotter92 that's true, but it still makes it more unwieldy to work with, slower to build etc. and so if there is a way to keep it down then that's probably worth exploring

@leszko
Copy link
Contributor

leszko commented Jul 4, 2023

I see the version 12.x is small, so we may upgrade to it. Just need to think how to test it.

@hjpotter92
Copy link
Member

I believe the last time this was discussed, @iameli raised an issue with ubuntu18.04 also getting bumped. if we're planning to keep ubuntu18.04 as the supported runtime version, we should go with 11.6.2 as that has the smallest image size.

however, if we're also planning to ditch the now EOL-ed ubuntu18.04, should we also consider ubuntu20? I believe when we reprovisioned our infra, the machines were installed with ubuntu20 (and that had been the concern last time this image was bumped).

@hjpotter92 hjpotter92 merged commit 4f701a9 into master Jul 18, 2023
16 checks passed
@hjpotter92 hjpotter92 deleted the md/fixDocker branch July 18, 2023 12:56
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request Aug 5, 2023
This was referenced Aug 8, 2023
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants