Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce configurable blacklist #2827

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Introduce configurable blacklist #2827

merged 1 commit into from
Jul 24, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jul 19, 2023

What does this pull request do? Explain your changes. (required)

Implement a configurable orchestrator blacklist. This has been requested so that we can exclude permanently poor performing orchestrators.

Specific updates (required)

The blacklist is set via a command line argument (comma separated list of addresses) and is eventually used by the discovery logic when choosing an orchestrator.

How did you test each of these updates (required)

  • existing unit tests adapted to cover this new scenario.
  • testing with a locally running version of B/O/T to confirm the changes work as expected in the overall app. Tested blacklisting my single O and observed no segments then being sent.

Does this pull request close any open issues?

Checklist:

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2827 (1bf6edb) into master (2b487db) will decrease coverage by 0.00267%.
The diff coverage is 62.50000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2827         +/-   ##
===================================================
- Coverage   56.74404%   56.74137%   -0.00267%     
===================================================
  Files             88          88                 
  Lines          19128       19143         +15     
===================================================
+ Hits           10854       10862          +8     
- Misses          7679        7686          +7     
  Partials         595         595                 
Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 4.26288% <0.00000%> (-0.02666%) ⬇️
discovery/db_discovery.go 70.32967% <100.00000%> (+0.10908%) ⬆️
discovery/discovery.go 92.12598% <100.00000%> (+0.45931%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b487db...1bf6edb. Read the comment docs.

Impacted Files Coverage Δ
cmd/livepeer/starter/starter.go 4.26288% <0.00000%> (-0.02666%) ⬇️
discovery/db_discovery.go 70.32967% <100.00000%> (+0.10908%) ⬆️
discovery/discovery.go 92.12598% <100.00000%> (+0.45931%) ⬆️

@thomshutt thomshutt marked this pull request as ready for review July 24, 2023 10:46
@thomshutt thomshutt merged commit 9e1924f into master Jul 24, 2023
16 checks passed
@thomshutt thomshutt deleted the mh/orch-blacklist branch July 24, 2023 10:48
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request Aug 5, 2023
This was referenced Aug 8, 2023
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants