Set a floor of 1.5s for threshold to switch Os #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
approved these changes
Aug 9, 2023
Merged
eliteprox
pushed a commit
to eliteprox/go-livepeer
that referenced
this pull request
Feb 21, 2024
* Set a floor of 1.5s for threshold to switch Os * Update tests to account for new minimum timeout * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
We currently have a threshold of
1*<segment duration>for decided when to swap to another Orchestrator, to ensure we're transcoding in realtime.This has been observed to be overly aggressive for 1s segments however, where even high-performing Orchestrators will sit very close to the limit.
Rather than incurring the overheads of swapping for Os that are otherwise keeping up, we're setting a floor of 1.5s for transcoding duration.
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
No
Checklist:
makeruns successfully./test.shpass