broadcaster introspection: update verification sigverification #2844
Conversation
|
Logs from github action test run on my repo Logs from local test of transcoding (cpu transcoding :)) |
verification/verify.go
Outdated
| @@ -184,7 +184,7 @@ func IsRetryable(err error) bool { | |||
| } | |||
|
|
|||
| func (sv *SegmentVerifier) sigVerification(params *Params) error { | |||
| if params.Orchestrator == nil || params.Orchestrator.TicketParams == nil { | |||
| if params.Orchestrator == nil || params.Orchestrator.Address == nil { | |||
There was a problem hiding this comment.
Should it actually exit early in both cases, like this?
if params.Orchestrator == nil || params.Orchestrator.Address == nil || params.Orchestrator.TicketParams == nil {
return nil
}Otherwise, I guess we can get panic in the next lines.
There was a problem hiding this comment.
Yes, this is better. I will update.
Codecov Report
@@ Coverage Diff @@
## master #2844 +/- ##
=============================================
Coverage 56.70668% 56.70668%
=============================================
Files 88 88
Lines 19160 19160
=============================================
Hits 10865 10865
Misses 7699 7699
Partials 596 596
Continue to review full report in Codecov by Sentry.
|
|
@ad-astra-video Please ping me when your PR is ready to review again. Thanks. |
|
@leszko ready to review. Had to update a couple tests to account for having three exit early tests in |
|
@ad-astra-video Approved, thanks for the PR. I'll merge it as soon as all the CI builds are completed. |
…eer#2844) * update verify.go sigVerification to return early if sess.Address() is nil instead of TicketParams * update verify_test.go for change in early exit of sigVerification * update test broadcastsession to add TicketParams.Recipient * update sigVerification early exit per comment * update tests for early exit change in sigVerification --------- Co-authored-by: Rafał Leszko <[email protected]>
What does this pull request do? Explain your changes. (required)
Update verification to exit early if
OrchestratorInfo.Addressis nil rather thanOrchestratorInfo.TicketParams.Recipient.This is a PR that will allow to log the on chain Orchestrator eth address with broadcaster introspection.
For additional discussion: #2840 (comment)
Specific updates (required)
sigVerificationfunction to exit early ifOrchestratorInfo.Addressis nil rather thanOrchestratorInfo.TicketParams.Recipient.How did you test each of these updates (required)
Does this pull request close any open issues?
No
Checklist:
makeruns successfully./test.shpass