Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Transcode Quality #2848

Merged
merged 9 commits into from
Sep 14, 2023
Merged

Improve Transcode Quality #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
57e3576
Update LPMS dependency
leszko Aug 29, 2023
c4612a0
Add CRF parameter to the video profile in the network communication
leszko Aug 29, 2023
b979078
Update LPMS
leszko Aug 29, 2023
ecf960b
Add CRF to segment_rpc.go
leszko Aug 29, 2023
ccba508
Update LPMS dep
leszko Sep 6, 2023
d0056cf
Merge branch 'master' into rafal/transcode-quality-params
leszko Sep 6, 2023
01d196e
Rename CRF to Quality to avoid the confusion
leszko Sep 8, 2023
7f1a288
Merge branch 'master' into rafal/transcode-quality-params
leszko Sep 8, 2023
8e486a1
Update LPMS dependency
leszko Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions common/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@
Encoder: encoder,
ColorDepth: int32(profile.ColorDepth),
ChromaFormat: chromaFormat,
Quality: uint32(profile.Quality),
}
profiles = append(profiles, &fullProfile)
}
Expand Down Expand Up @@ -478,7 +479,7 @@
if len(cards) != 0 {
for _, card := range cards {
if card.DeviceInfo != nil && re.MatchString(card.DeviceInfo.Vendor.Name) {
nvidiaCardCount += 1

Check warning on line 482 in common/util.go

View workflow job for this annotation

GitHub Actions / Run tests defined for the project 

should replace nvidiaCardCount += 1 with nvidiaCardCount++
}
}
} else { // on VMs gpu.GraphicsCards may be empty
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/jaypipes/pcidb v1.0.0
github.com/livepeer/go-tools v0.0.0-20220805063103-76df6beb6506
github.com/livepeer/livepeer-data v0.7.2-0.20230601112542-e54477bc9479
github.com/livepeer/lpms v0.0.0-20230125115958-32cd1538cc04
github.com/livepeer/lpms v0.0.0-20230914095059-f59041708b97
github.com/livepeer/m3u8 v0.11.1
github.com/mattn/go-sqlite3 v1.14.16
github.com/olekukonko/tablewriter v0.0.5
Expand Down
10 changes: 10 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,16 @@ github.com/livepeer/livepeer-data v0.7.2-0.20230601112542-e54477bc9479 h1:oZlEaa
github.com/livepeer/livepeer-data v0.7.2-0.20230601112542-e54477bc9479/go.mod h1:Jpf4jHK+fbWioBHRDRM1WadNT1qmY27g2YicTdO0Rtc=
github.com/livepeer/lpms v0.0.0-20230125115958-32cd1538cc04 h1:pl7pF/TOAU9+lBbaehu4+2wn1mn6iB5AhPtysMLzjSI=
github.com/livepeer/lpms v0.0.0-20230125115958-32cd1538cc04/go.mod h1:Hr/JhxxPDipOVd4ZrGYWrdJfpVF8/SEI0nNr2ctAlkM=
github.com/livepeer/lpms v0.0.0-20230829103633-3948710a15cb h1:Cl0zInI5J+ZSNmx0e2jfgXvYHtynW3TDkU3oT8TIm0Q=
github.com/livepeer/lpms v0.0.0-20230829103633-3948710a15cb/go.mod h1:Hr/JhxxPDipOVd4ZrGYWrdJfpVF8/SEI0nNr2ctAlkM=
github.com/livepeer/lpms v0.0.0-20230829131239-e9afe5decc7b h1:mSNDvKVVqU1sfkvADf7Ph3PCklE3yIYlvydE9O9vX6k=
github.com/livepeer/lpms v0.0.0-20230829131239-e9afe5decc7b/go.mod h1:Hr/JhxxPDipOVd4ZrGYWrdJfpVF8/SEI0nNr2ctAlkM=
github.com/livepeer/lpms v0.0.0-20230830120957-e8052f0da24e h1:2dTDAyjbHe5GNzik6O5UnecMPdv85nClo/TJCRQRdjw=
github.com/livepeer/lpms v0.0.0-20230830120957-e8052f0da24e/go.mod h1:Hr/JhxxPDipOVd4ZrGYWrdJfpVF8/SEI0nNr2ctAlkM=
github.com/livepeer/lpms v0.0.0-20230908073450-33906e16825a h1:jwcXUPAGkF8hycp9A5/0KGqIZ468dZDGDigy4llDYCk=
github.com/livepeer/lpms v0.0.0-20230908073450-33906e16825a/go.mod h1:Hr/JhxxPDipOVd4ZrGYWrdJfpVF8/SEI0nNr2ctAlkM=
github.com/livepeer/lpms v0.0.0-20230914095059-f59041708b97 h1:RDM5vkKbNHarkI6+OjqHFIbpg30pU7PcEUO5I1k03g8=
github.com/livepeer/lpms v0.0.0-20230914095059-f59041708b97/go.mod h1:Hr/JhxxPDipOVd4ZrGYWrdJfpVF8/SEI0nNr2ctAlkM=
github.com/livepeer/m3u8 v0.11.1 h1:VkUJzfNTyjy9mqsgp5JPvouwna8wGZMvd/gAfT5FinU=
github.com/livepeer/m3u8 v0.11.1/go.mod h1:IUqAtwWPAG2CblfQa4SVzTQoDcEMPyfNOaBSxqHMS04=
github.com/magiconair/properties v1.8.5 h1:b6kJs+EmPFMYGkow9GiUyCyOvIwYetYJ3fSaWak/Gls=
Expand Down
Loading
Loading