Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ports to be different for B / O / T #2850

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

ad-astra-video
Copy link
Contributor

@ad-astra-video ad-astra-video commented Aug 31, 2023

What does this pull request do? Explain your changes. (required)
Updates ports as suggested in #2797

@chrishobcroft

Specific updates (required)

  • updated starter.go to use separate ports

How did you test each of these updates (required)

  • ran test.sh and starter.go tests passed

Does this pull request close any open issues?
See above.

Checklist:

  • Read the contribution guide
  • make runs successfully
  • All tests in ./test.sh pass I think the test that is failing is not caused by this update but please confirm.
  • README and other documentation updated
  • Pending changelog updated

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, but I see that e2e tests are failing.

E0831 13:58:06.488086   20826 gaspricemonitor.go:122] error getting gas price: Post "http://172.17.0.1:32779/": read tcp 172.18.0.2:39278->172.17.0.1:32779: read: connection reset by peer
E0831 13:58:06.661925   20826 webserver.go:22] http: Server closed
FAIL
FAIL	github.com/livepeer/go-livepeer/test/e2e	326.824s
FAIL
Error: Process completed with exit code 1.

Could you please check?

@ad-astra-video
Copy link
Contributor Author

Can you try re-running the test? I think the one that is failing is one of the problem tests. The tests pass on my test run but had to run twice.

https://github.com/ad-astra-video/go-livepeer/actions/runs/6084402253

@leszko
Copy link
Contributor

leszko commented Sep 5, 2023

Can you try re-running the test? I think the one that is failing is one of the problem tests. The tests pass on my test run but had to run twice.

https://github.com/ad-astra-video/go-livepeer/actions/runs/6084402253

Yeah, that's possible. I think that you need to resolve the conflicts and then when you push the build should pass.

@ad-astra-video
Copy link
Contributor Author

Can you try re-running the test? I think the one that is failing is one of the problem tests. The tests pass on my test run but had to run twice.
https://github.com/ad-astra-video/go-livepeer/actions/runs/6084402253

Yeah, that's possible. I think that you need to resolve the conflicts and then when you push the build should pass.

These conflicts are the changes I made for the ports right? Am I missing something?

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2850 (370be5f) into master (a231510) will decrease coverage by 0.20483%.
Report is 7 commits behind head on master.
The diff coverage is 8.03571%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2850         +/-   ##
===================================================
- Coverage   56.70668%   56.50185%   -0.20483%     
===================================================
  Files             88          88                 
  Lines          19160       19233         +73     
===================================================
+ Hits           10865       10867          +2     
- Misses          7699        7767         +68     
- Partials         596         599          +3     
Files Changed Coverage Δ
clog/clog.go 59.87261% <ø> (ø)
cmd/livepeer/starter/starter.go 4.21053% <0.00000%> (-0.05235%) ⬇️
cmd/livepeer_cli/livepeer_cli.go 0.00000% <ø> (ø)
cmd/livepeer_cli/wizard_bond.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_rounds.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_stats.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)
core/livepeernode.go 60.00000% <0.00000%> (-18.00000%) ⬇️
server/handlers.go 53.07018% <5.55556%> (-0.76226%) ⬇️
core/orchestrator.go 77.71664% <25.00000%> (-0.61669%) ⬇️
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb2d49...370be5f. Read the comment docs.

Files Changed Coverage Δ
clog/clog.go 59.87261% <ø> (ø)
cmd/livepeer/starter/starter.go 4.21053% <0.00000%> (-0.05235%) ⬇️
cmd/livepeer_cli/livepeer_cli.go 0.00000% <ø> (ø)
cmd/livepeer_cli/wizard_bond.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_rounds.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_stats.go 0.00000% <0.00000%> (ø)
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)
core/livepeernode.go 60.00000% <0.00000%> (-18.00000%) ⬇️
server/handlers.go 53.07018% <5.55556%> (-0.76226%) ⬇️
core/orchestrator.go 77.71664% <25.00000%> (-0.61669%) ⬇️
... and 4 more

@leszko leszko merged commit 86b248d into livepeer:master Sep 6, 2023
15 of 16 checks passed
@eliteprox
Copy link
Contributor

Good work, this will make running the full stack much easier on a single machine.

@chrishobcroft
Copy link
Contributor

Thank you @ad-astra-video this works nicely!

eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants