Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update currentRound endpoint to return string instead of bytes #2859

Merged

Conversation

ad-astra-video
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Updates currentRound web endpoint to return a string rather than big.Int.Bytes().

Makes it easier to pull from livepeer node by curl request and outside call to web endpoint.

Specific updates (required)

  • currentRound handler updated to return string instead of big.Int.Bytes()
  • livepeer_cli updated to handle new return value
  • test updated

How did you test each of these updates (required)
ran test suite on fork of go-livepeer https://github.com/ad-astra-video/go-livepeer/actions/runs/6109883984

Does this pull request close any open issues?
No

Checklist:

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2859 (cf67ca5) into master (4a4a956) will increase coverage by 0.00385%.
The diff coverage is 16.66667%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2859         +/-   ##
===================================================
+ Coverage   56.48625%   56.49010%   +0.00385%     
===================================================
  Files             88          88                 
  Lines          19233       19237          +4     
===================================================
+ Hits           10864       10867          +3     
- Misses          7770        7771          +1     
  Partials         599         599                 
Files Changed Coverage Δ
cmd/livepeer_cli/wizard_rounds.go 0.00000% <0.00000%> (ø)
server/handlers.go 53.07018% <100.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4a956...cf67ca5. Read the comment docs.

Files Changed Coverage Δ
cmd/livepeer_cli/wizard_rounds.go 0.00000% <0.00000%> (ø)
server/handlers.go 53.07018% <100.00000%> (ø)

... and 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@leszko leszko merged commit a3e725c into livepeer:master Sep 8, 2023
15 of 16 checks passed
ad-astra-video added a commit to ad-astra-video/go-livepeer that referenced this pull request Sep 12, 2023
ad-astra-video added a commit to ad-astra-video/go-livepeer that referenced this pull request Sep 12, 2023
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants