Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detailed scores logging #2877

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 2, 2023

It was a leftover. I think we should not print it, because it's too detailed.

@leszko leszko requested a review from thomshutt October 2, 2023 09:31
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2877 (55727af) into master (c9f47f4) will decrease coverage by 0.01774%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2877         +/-   ##
===================================================
- Coverage   56.40748%   56.38974%   -0.01774%     
===================================================
  Files             89          89                 
  Lines          19368       19367          -1     
===================================================
- Hits           10925       10921          -4     
- Misses          7839        7842          +3     
  Partials         604         604                 
Files Coverage Δ
cmd/livepeer/starter/starter.go 4.72637% <ø> (-0.07893%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9f47f4...55727af. Read the comment docs.

Files Coverage Δ
cmd/livepeer/starter/starter.go 4.72637% <ø> (-0.07893%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you just throw a line in the PR description about why you're doing this please

@leszko leszko merged commit 43035a7 into master Oct 2, 2023
19 checks passed
@leszko leszko deleted the rafal/remove-detailed-scores-logging branch October 2, 2023 13:14
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants