Detect resolution change and reinit hw session

[leszko]

It reinitializes the hw session if there is a mismatch in media info between segments.

Note that it does not fix the issue completely, because if the resolution is changed inside a segment, then the given segment is not transcoded correctly. But it makes the issue way less problematic, becuase all consecutive segments are ok.

fix https://linear.app/livepeer/issue/VID-438/analyze-pink-and-green-lines-in-transcoded-video

[linear]

VID-438 Analyze pink and green lines in transcoded video

Sample source video: https://link.storjshare.io/raw/juixm77hfsmhyslrxtycnqfmnlfq/catalyst-recordings-com/hls/db4f9ue48uapp6i6/9c1e07f6-3f70-48f7-8ff3-12b42e7728f2/output.m3u8

Transcoded video: https://storage.googleapis.com/lp-us-catalyst-vod-com/hls/9c1ecrlde2bwedaa/index.m3u8

[codecov]

Codecov Report

Merging #2884 (81b6ffc) into master (45a03e7) will increase coverage by 0.02924%.
The diff coverage is 100.00000%.

@@                 Coverage Diff                 @@
##              master       #2884         +/-   ##
===================================================
+ Coverage   56.38155%   56.41079%   +0.02924%     
===================================================
  Files             89          89                 
  Lines          19384       19397         +13     
===================================================
+ Hits           10929       10942         +13     
  Misses          7849        7849                 
  Partials         606         606                 

Files	Coverage Δ
server/broadcast.go	77.66831% <100.00000%> (+0.05514%)	⬆️
server/mediaserver.go	67.47536% <100.00000%> (+0.24847%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a03e7...81b6ffc. Read the comment docs.

Files	Coverage Δ
server/broadcast.go	77.66831% <100.00000%> (+0.05514%)	⬆️
server/mediaserver.go	67.47536% <100.00000%> (+0.24847%)	⬆️

[thomshutt]

LGTM, is there any easy way we can track how often the session reinits are happening?

[leszko]

LGTM, is there any easy way we can track how often the session reinits are happening?

Good point, added logging when HW Session Reinit is requested. PTAL: 81b6ffc

[thomshutt]

LGTM, is there any easy way we can track how often the session reinits are happening?

Good point, added logging when HW Session Reinit is requested. PTAL: 81b6ffc

Looks good! 🚢 🇮🇹