Initialize default metrics to 0 #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
requested changes
Oct 11, 2023
Moved functions to // init metrics values SetTranscodersNumberAndLoad(0, 0, 0)
leszko
requested changes
Oct 23, 2023
Removed lines from first change
leszko
reviewed
Oct 24, 2023
Codecov Report
@@ Coverage Diff @@
## master #2888 +/- ##
===================================================
+ Coverage 56.45311% 56.47301% +0.01990%
===================================================
Files 89 89
Lines 19448 19450 +2
===================================================
+ Hits 10979 10984 +5
+ Misses 7861 7858 -3
Partials 608 608
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
leszko
reviewed
Oct 24, 2023
leszko
approved these changes
Oct 24, 2023
|
The CI build fails, but passes when I tried with a fresh PR #2898. Merging then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Initialize Winning Tickets and Current Sessions to 0
Specific updates (required)
How did you test each of these updates (required)
Built code locally and deployed to production orchestrator
Does this pull request close any open issues?
No
Checklist:
makeruns successfully./test.shpass