Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate cost using a framerate of 60 rather than 120 #2896

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

thomshutt
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
We've found that in reality, no assets we receive have a framerate of 120 and so as a stopgap improvement until we start pulling the true FPS, we're going to calculate our estimate with a framerate of 60 instead.

Specific updates (required)

  • Change cost estimation default framerate from 120 -> 60

How did you test each of these updates (required)

  • Ran test suite

Does this pull request close any open issues?
No

Checklist:

@leszko
Copy link
Contributor

leszko commented Oct 19, 2023

@thomshutt Note the CI Test failures. Please check it before merging.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2896 (521f3c2) into master (32d5d45) will increase coverage by 0.01509%.
Report is 1 commits behind head on master.
The diff coverage is 73.80952%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2896         +/-   ##
===================================================
+ Coverage   56.45344%   56.46853%   +0.01509%     
===================================================
  Files             89          89                 
  Lines          19416       19448         +32     
===================================================
+ Hits           10961       10982         +21     
- Misses          7849        7858          +9     
- Partials         606         608          +2     
Files Coverage Δ
core/accounting.go 100.00000% <100.00000%> (ø)
server/broadcast.go 77.97571% <100.00000%> (+0.01785%) ⬆️
server/rpc.go 72.10682% <100.00000%> (ø)
server/segment_rpc.go 78.48837% <100.00000%> (+0.12580%) ⬆️
core/orchestrator.go 76.58999% <26.66667%> (-1.12665%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cc5c8...521f3c2. Read the comment docs.

Files Coverage Δ
core/accounting.go 100.00000% <100.00000%> (ø)
server/broadcast.go 77.97571% <100.00000%> (+0.01785%) ⬆️
server/rpc.go 72.10682% <100.00000%> (ø)
server/segment_rpc.go 78.48837% <100.00000%> (+0.12580%) ⬆️
core/orchestrator.go 76.58999% <26.66667%> (-1.12665%) ⬇️

@thomshutt thomshutt merged commit 1c2ce07 into master Oct 19, 2023
18 checks passed
@thomshutt thomshutt deleted the framerate-120 branch October 19, 2023 11:03
@thomshutt thomshutt mentioned this pull request Jan 29, 2024
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
* Estimate cost using a framerate of 60 rather than 120

* Update test with new estimation numbers

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants