Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of glog.fatal #2900

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Get rid of glog.fatal #2900

merged 1 commit into from
Oct 26, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 25, 2023

We should not use glog.fatal(), because its behavior changed in the glog library and now it prints the stack dump of each goroutine. This results in too many logs printed even if you enter a wrong parameter in your configuration.

@leszko leszko requested a review from thomshutt October 25, 2023 13:58
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2900 (954e437) into master (366c2d6) will increase coverage by 0.02523%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2900         +/-   ##
===================================================
+ Coverage   56.47192%   56.49715%   +0.02523%     
===================================================
  Files             89          89                 
  Lines          19461       19447         -14     
===================================================
- Hits           10990       10987          -3     
+ Misses          7863        7852         -11     
  Partials         608         608                 
Files Coverage Δ
clog/clog.go 62.25166% <ø> (+2.37905%) ⬆️
cmd/livepeer_cli/wizard_stream.go 0.00000% <ø> (ø)
cmd/livepeer/livepeer.go 50.00000% <0.00000%> (ø)
monitor/census.go 63.30709% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 4.73422% <0.00000%> (+0.02737%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366c2d6...954e437. Read the comment docs.

Files Coverage Δ
clog/clog.go 62.25166% <ø> (+2.37905%) ⬆️
cmd/livepeer_cli/wizard_stream.go 0.00000% <ø> (ø)
cmd/livepeer/livepeer.go 50.00000% <0.00000%> (ø)
monitor/census.go 63.30709% <0.00000%> (ø)
cmd/livepeer/starter/starter.go 4.73422% <0.00000%> (+0.02737%) ⬆️

... and 1 file with indirect coverage changes

@leszko leszko merged commit b954a1c into master Oct 26, 2023
18 checks passed
@leszko leszko deleted the rafal/get-rid-of-fatal-logs branch October 26, 2023 09:00
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants