Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default price with cli option 20 #2911

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

eliteprox
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

This change allows us to set the base price per pixel with option 20. Set price for broadcaster in livepeer_cli. It is simpler to use than 13. Set orchestrator config.

Specific updates (required)

  • Updates input validation for livepeer_cli to allow default to be used in place of eth address
  • Defaults no input for eth address to default

How did you test each of these updates (required)

  • eth address field empty, set price and verified the base price per pixel was set
  • invalid eth address and confirmed Failed to validate input
  • valid eth address and confirmed it was accepted.
  • Ran applicable tests

Does this pull request close any open issues?
None

Checklist:

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2911 (fd7f7ec) into master (68c80a1) will not change coverage.
The diff coverage is 0.00000%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #2911   +/-   ##
=============================================
  Coverage   56.54162%   56.54162%           
=============================================
  Files             89          89           
  Lines          19460       19460           
=============================================
  Hits           11003       11003           
  Misses          7849        7849           
  Partials         608         608           
Files Coverage Δ
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c80a1...fd7f7ec. Read the comment docs.

Files Coverage Δ
cmd/livepeer_cli/wizard_transcoder.go 0.00000% <0.00000%> (ø)

Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change!

@thomshutt thomshutt merged commit 5b69cd6 into livepeer:master Dec 7, 2023
16 of 17 checks passed
@thomshutt thomshutt mentioned this pull request Jan 29, 2024
eliteprox added a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants